Skip to content

deps: upgrade npm to 6.9.1#28441

Closed
isaacs wants to merge 1 commit into
nodejs:masterfrom
npm:npm-6.9.1
Closed

deps: upgrade npm to 6.9.1#28441
isaacs wants to merge 1 commit into
nodejs:masterfrom
npm:npm-6.9.1

Conversation

@isaacs

@isaacs isaacs commented Jun 26, 2019

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Where this should land
  • Node 12
  • Node 10
  • Node 8
Notable changes
  • none
Changelogs

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Jun 26, 2019

@Trott Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@isaacs

isaacs commented Jul 3, 2019

Copy link
Copy Markdown
Contributor Author

Do not land. There's an issue with this build that is fixed in 6.9.2 and (better) in 6.10.0.

@isaacs isaacs closed this Jul 3, 2019
@isaacs isaacs mentioned this pull request Jul 3, 2019
4 tasks
@wraithgar wraithgar deleted the npm-6.9.1 branch June 26, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants